From d191cf92469da665c0018d0abde55ea3fd8e68a8 Mon Sep 17 00:00:00 2001
From: dataking <dataking@gmail.com>
Date: Sun, 31 Jul 2016 21:26:15 -0700
Subject: [PATCH] cleaning up some listboxes

---
 lynis_report.pl | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/lynis_report.pl b/lynis_report.pl
index 8399dfc..cda247c 100755
--- a/lynis_report.pl
+++ b/lynis_report.pl
@@ -344,7 +344,11 @@ END
 	if ((exists($lynis_report_data{'deleted_file[]'})) and ($lynis_report_data{'deleted_file[]'} ne "")) {
 		if (ref($lynis_report_data{'deleted_file[]'}) eq 'ARRAY') {
 			print OUT "\t\t\t\t<h5>deleted files (".scalar(@{$lynis_report_data{'deleted_file[]'}})."):</h5>\n";
-			print OUT "\t\t\t\t<select size=\"10\" name=\"lbDeletedFiles\">\n";
+			if (scalar(@{$lynis_report_data{'deleted_file[]'}}) < 10) {
+				print OUT "\t\t\t\t<select size=\"".scalar(@{$lynis_report_data{'deleted_file[]'}})."\" name=\"lbDeletedFiles\">\n";
+			} else {
+				print OUT "\t\t\t\t<select size=\"10\" name=\"lbDeletedFiles\">\n";
+			}
 			foreach my $f ( @{$lynis_report_data{'deleted_file[]'}} ) { print OUT "\t\t\t\t\t<option>$f\n"; }
 		} else {
 			warn colored("Deleted files object not an array! \n", "yellow");
@@ -421,7 +425,11 @@ END
 	if ((exists($lynis_report_data{'plugin_processes_allprocesses'})) and ($lynis_report_data{'plugin_processes_allprocesses'} ne "")) {
 		print OUT "\t\t\t\t<h5>Plugin-processes: discovered processes:</h5>\n";
 		if (ref($lynis_report_data{'plugin_processes_allprocesses'}) eq 'ARRAY') {
-			print OUT "\t\t\t\t\t<select size=\"10\" name=\"lbPluginProcessesAllProcesses\" >\n";
+			if (scalar(@{$lynis_report_data{'plugin_processes_allprocesses'}}) < 10) {
+				print OUT "\t\t\t\t\t\t<select size=\"".scalar(@{$lynis_report_data{'plugin_processes_allprocesses'}})."\" name=\"lbPluginProcessesAllProcesses\" >\n";
+			} else {
+				print OUT "\t\t\t\t\t<select size=\"10\" name=\"lbPluginProcessesAllProcesses\" >\n";
+			}
 			foreach my $p ( sort @{$lynis_report_data{'plugin_processes_allprocesses'}} ) { print OUT "\t\t\t\t\t\t<option>$p\n"; }
 			print OUT "\t\t\t\t\t</select>\n";
 		} else {
@@ -527,13 +535,21 @@ END
 				<h4>log directories:</h4>
 END
 	if (ref($lynis_report_data{'log_directory[]'}) eq 'ARRAY') {
-		print OUT "\t\t\t\t\t<select size=\"10\" name=\"lbLogDirectories\">\n";
+		if (scalar(@{$lynis_report_data{'log_directory[]'}}) < 10) {
+			print OUT "\t\t\t\t\t<select size=\"".scalar(@{$lynis_report_data{'log_directory[]'}})."\" name=\"lbLogDirectories\">\n";
+		} else {
+			print OUT "\t\t\t\t\t<select size=\"10\" name=\"lbLogDirectories\">\n";
+		}
 		foreach my $ld ( @{$lynis_report_data{'log_directory[]'}} ) { print OUT "\t\t\t\t\t\t<option>$ld\n"; }
 		print OUT "\t\t\t\t\t</select>\n";
 	}
 	print OUT "\t\t\t\t\t<h4>open log files:</h4>\n";
 	if (ref($lynis_report_data{'open_logfile[]'}) eq 'ARRAY') {
-		print OUT "\t\t\t\t\t<select size=\"10\" name=\"blOpenLogFiles\">\n";
+		if (scalar(@{$lynis_report_data{'open_logfile[]'}}) < 10) {
+			print OUT "\t\t\t\t\t<select size=\"".scalar(@{$lynis_report_data{'open_logfile[]'}})."\" name=\"blOpenLogFiles\">\n";
+		} else {
+			print OUT "\t\t\t\t\t<select size=\"10\" name=\"blOpenLogFiles\">\n";
+		}
 		foreach my $lf ( @{$lynis_report_data{'open_logfile[]'}} ) { print OUT "\t\t\t\t\t\t<option>$lf\n"; }
 		print OUT "\t\t\t\t\t</select>\n";
 	}