borekon/disposable-mailbox
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix warnings in imap_client

Browse Source
This commit is contained in:
Synox 2018-03-06 22:43:52 +01:00
parent 5ced6b93df
commit cbfa9571cd
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/imap_client.php
View File

@ -46,15 +46,15 @@ class ImapClient {
/** /**
* Load exactly one email, the $address in TO or CC has to match. * Load exactly one email, the $address in TO or CC has to match.
*/ */
public function load_one_email(int $mailid, User $user): \PhpImap\IncomingMail { public function load_one_email(int $mailid, User $user): ?\PhpImap\IncomingMail {
// in order to avoid https://www.owasp.org/index.php/Top_10_2013-A4-Insecure_Direct_Object_References // in order to avoid https://www.owasp.org/index.php/Top_10_2013-A4-Insecure_Direct_Object_References
// the recipient in the email has to match the $address. // the recipient in the email has to match the $address.
$emails = $this->_load_emails(array($mailid), $user); @$emails = $this->_load_emails(array($mailid), $user);
return count($emails) === 1 ? $emails[0] : null; return count($emails) === 1 ? $emails[0] : null;
} }
public function load_one_email_fully($download_email_id, $user) { public function load_one_email_fully($download_email_id, $user): ?string {
if ($this->load_one_email($download_email_id, $user) !== null) { if ($this->load_one_email($download_email_id, $user) !== null) {
$headers = imap_fetchheader($this->mailbox->getImapStream(), $download_email_id, FT_UID); $headers = imap_fetchheader($this->mailbox->getImapStream(), $download_email_id, FT_UID);
$body = imap_body($this->mailbox->getImapStream(), $download_email_id, FT_UID); $body = imap_body($this->mailbox->getImapStream(), $download_email_id, FT_UID);