
* Add external channel URL for channel update / creation (#754) * Disallow synchronisation if user has no video quota (#754) * More constraints serverside (#754) * Disable sync if server configuration does not allow HTTP import (#754) * Working version synchronizing videos with a job (#754) TODO: refactoring, too much code duplication * More logs and try/catch (#754) * Fix eslint error (#754) * WIP: support synchronization time change (#754) * New frontend #754 * WIP: Create sync front (#754) * Enhance UI, sync creation form (#754) * Warning message when HTTP upload is disallowed * More consistent names (#754) * Binding Front with API (#754) * Add a /me API (#754) * Improve list UI (#754) * Implement creation and deletion routes (#754) * Lint (#754) * Lint again (#754) * WIP: UI for triggering import existing videos (#754) * Implement jobs for syncing and importing channels * Don't sync videos before sync creation + avoid concurrency issue (#754) * Cleanup (#754) * Cleanup: OpenAPI + API rework (#754) * Remove dead code (#754) * Eslint (#754) * Revert the mess with whitespaces in constants.ts (#754) * Some fixes after rebase (#754) * Several fixes after PR remarks (#754) * Front + API: Rename video-channels-sync to video-channel-syncs (#754) * Allow enabling channel sync through UI (#754) * getChannelInfo (#754) * Minor fixes: openapi + model + sql (#754) * Simplified API validators (#754) * Rename MChannelSync to MChannelSyncChannel (#754) * Add command for VideoChannelSync (#754) * Use synchronization.enabled config (#754) * Check parameters test + some fixes (#754) * Fix conflict mistake (#754) * Restrict access to video channel sync list API (#754) * Start adding unit test for synchronization (#754) * Continue testing (#754) * Tests finished + convertion of job to scheduler (#754) * Add lastSyncAt field (#754) * Fix externalRemoteUrl sort + creation date not well formatted (#754) * Small fix (#754) * Factorize addYoutubeDLImport and buildVideo (#754) * Check duplicates on channel not on users (#754) * factorize thumbnail generation (#754) * Fetch error should return status 400 (#754) * Separate video-channel-import and video-channel-sync-latest (#754) * Bump DB migration version after rebase (#754) * Prettier states in UI table (#754) * Add DefaultScope in VideoChannelSyncModel (#754) * Fix audit logs (#754) * Ensure user can upload when importing channel + minor fixes (#754) * Mark synchronization as failed on exception + typos (#754) * Change REST API for importing videos into channel (#754) * Add option for fully synchronize a chnanel (#754) * Return a whole sync object on creation to avoid tricks in Front (#754) * Various remarks (#754) * Single quotes by default (#754) * Rename synchronization to video_channel_synchronization * Add check.latest_videos_count and max_per_user options (#754) * Better channel rendering in list #754 * Allow sorting with channel name and state (#754) * Add missing tests for channel imports (#754) * Prefer using a parent job for channel sync * Styling * Client styling Co-authored-by: Chocobozzz <me@florianbigard.com>
492 lines
16 KiB
TypeScript
492 lines
16 KiB
TypeScript
/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */
|
|
|
|
import 'mocha'
|
|
import * as chai from 'chai'
|
|
import { omit } from 'lodash'
|
|
import { checkBadCountPagination, checkBadSortPagination, checkBadStartPagination, FIXTURE_URLS } from '@server/tests/shared'
|
|
import { areHttpImportTestsDisabled, buildAbsoluteFixturePath } from '@shared/core-utils'
|
|
import { HttpStatusCode, VideoChannelUpdate } from '@shared/models'
|
|
import {
|
|
ChannelsCommand,
|
|
cleanupTests,
|
|
createSingleServer,
|
|
makeGetRequest,
|
|
makePostBodyRequest,
|
|
makePutBodyRequest,
|
|
makeUploadRequest,
|
|
PeerTubeServer,
|
|
setAccessTokensToServers
|
|
} from '@shared/server-commands'
|
|
|
|
const expect = chai.expect
|
|
|
|
describe('Test video channels API validator', function () {
|
|
const videoChannelPath = '/api/v1/video-channels'
|
|
let server: PeerTubeServer
|
|
const userInfo = {
|
|
accessToken: '',
|
|
channelName: 'fake_channel',
|
|
id: -1,
|
|
videoQuota: -1,
|
|
videoQuotaDaily: -1
|
|
}
|
|
let command: ChannelsCommand
|
|
|
|
// ---------------------------------------------------------------
|
|
|
|
before(async function () {
|
|
this.timeout(30000)
|
|
|
|
server = await createSingleServer(1)
|
|
|
|
await setAccessTokensToServers([ server ])
|
|
|
|
const userCreds = {
|
|
username: 'fake',
|
|
password: 'fake_password'
|
|
}
|
|
|
|
{
|
|
const user = await server.users.create({ username: userCreds.username, password: userCreds.password })
|
|
userInfo.id = user.id
|
|
userInfo.accessToken = await server.login.getAccessToken(userCreds)
|
|
}
|
|
|
|
command = server.channels
|
|
})
|
|
|
|
describe('When listing a video channels', function () {
|
|
it('Should fail with a bad start pagination', async function () {
|
|
await checkBadStartPagination(server.url, videoChannelPath, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with a bad count pagination', async function () {
|
|
await checkBadCountPagination(server.url, videoChannelPath, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with an incorrect sort', async function () {
|
|
await checkBadSortPagination(server.url, videoChannelPath, server.accessToken)
|
|
})
|
|
})
|
|
|
|
describe('When listing account video channels', function () {
|
|
const accountChannelPath = '/api/v1/accounts/fake/video-channels'
|
|
|
|
it('Should fail with a bad start pagination', async function () {
|
|
await checkBadStartPagination(server.url, accountChannelPath, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with a bad count pagination', async function () {
|
|
await checkBadCountPagination(server.url, accountChannelPath, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with an incorrect sort', async function () {
|
|
await checkBadSortPagination(server.url, accountChannelPath, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with a unknown account', async function () {
|
|
await server.channels.listByAccount({ accountName: 'unknown', expectedStatus: HttpStatusCode.NOT_FOUND_404 })
|
|
})
|
|
|
|
it('Should succeed with the correct parameters', async function () {
|
|
await makeGetRequest({
|
|
url: server.url,
|
|
path: accountChannelPath,
|
|
expectedStatus: HttpStatusCode.OK_200
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('When adding a video channel', function () {
|
|
const baseCorrectParams = {
|
|
name: 'super_channel',
|
|
displayName: 'hello',
|
|
description: 'super description',
|
|
support: 'super support text'
|
|
}
|
|
|
|
it('Should fail with a non authenticated user', async function () {
|
|
await makePostBodyRequest({
|
|
url: server.url,
|
|
path: videoChannelPath,
|
|
token: 'none',
|
|
fields: baseCorrectParams,
|
|
expectedStatus: HttpStatusCode.UNAUTHORIZED_401
|
|
})
|
|
})
|
|
|
|
it('Should fail with nothing', async function () {
|
|
const fields = {}
|
|
await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail without a name', async function () {
|
|
const fields = omit(baseCorrectParams, 'name')
|
|
await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad name', async function () {
|
|
const fields = { ...baseCorrectParams, name: 'super name' }
|
|
await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail without a name', async function () {
|
|
const fields = omit(baseCorrectParams, 'displayName')
|
|
await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a long name', async function () {
|
|
const fields = { ...baseCorrectParams, displayName: 'super'.repeat(25) }
|
|
await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a long description', async function () {
|
|
const fields = { ...baseCorrectParams, description: 'super'.repeat(201) }
|
|
await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a long support text', async function () {
|
|
const fields = { ...baseCorrectParams, support: 'super'.repeat(201) }
|
|
await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should succeed with the correct parameters', async function () {
|
|
await makePostBodyRequest({
|
|
url: server.url,
|
|
path: videoChannelPath,
|
|
token: server.accessToken,
|
|
fields: baseCorrectParams,
|
|
expectedStatus: HttpStatusCode.OK_200
|
|
})
|
|
})
|
|
|
|
it('Should fail when adding a channel with the same username', async function () {
|
|
await makePostBodyRequest({
|
|
url: server.url,
|
|
path: videoChannelPath,
|
|
token: server.accessToken,
|
|
fields: baseCorrectParams,
|
|
expectedStatus: HttpStatusCode.CONFLICT_409
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('When updating a video channel', function () {
|
|
const baseCorrectParams: VideoChannelUpdate = {
|
|
displayName: 'hello',
|
|
description: 'super description',
|
|
support: 'toto',
|
|
bulkVideosSupportUpdate: false
|
|
}
|
|
let path: string
|
|
|
|
before(async function () {
|
|
path = videoChannelPath + '/super_channel'
|
|
})
|
|
|
|
it('Should fail with a non authenticated user', async function () {
|
|
await makePutBodyRequest({
|
|
url: server.url,
|
|
path,
|
|
token: 'hi',
|
|
fields: baseCorrectParams,
|
|
expectedStatus: HttpStatusCode.UNAUTHORIZED_401
|
|
})
|
|
})
|
|
|
|
it('Should fail with another authenticated user', async function () {
|
|
await makePutBodyRequest({
|
|
url: server.url,
|
|
path,
|
|
token: userInfo.accessToken,
|
|
fields: baseCorrectParams,
|
|
expectedStatus: HttpStatusCode.FORBIDDEN_403
|
|
})
|
|
})
|
|
|
|
it('Should fail with a long name', async function () {
|
|
const fields = { ...baseCorrectParams, displayName: 'super'.repeat(25) }
|
|
await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a long description', async function () {
|
|
const fields = { ...baseCorrectParams, description: 'super'.repeat(201) }
|
|
await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a long support text', async function () {
|
|
const fields = { ...baseCorrectParams, support: 'super'.repeat(201) }
|
|
await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad bulkVideosSupportUpdate field', async function () {
|
|
const fields = { ...baseCorrectParams, bulkVideosSupportUpdate: 'super' }
|
|
await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should succeed with the correct parameters', async function () {
|
|
await makePutBodyRequest({
|
|
url: server.url,
|
|
path,
|
|
token: server.accessToken,
|
|
fields: baseCorrectParams,
|
|
expectedStatus: HttpStatusCode.NO_CONTENT_204
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('When updating video channel avatars/banners', function () {
|
|
const types = [ 'avatar', 'banner' ]
|
|
let path: string
|
|
|
|
before(async function () {
|
|
path = videoChannelPath + '/super_channel'
|
|
})
|
|
|
|
it('Should fail with an incorrect input file', async function () {
|
|
for (const type of types) {
|
|
const fields = {}
|
|
const attaches = {
|
|
[type + 'file']: buildAbsoluteFixturePath('video_short.mp4')
|
|
}
|
|
|
|
await makeUploadRequest({ url: server.url, path: `${path}/${type}/pick`, token: server.accessToken, fields, attaches })
|
|
}
|
|
})
|
|
|
|
it('Should fail with a big file', async function () {
|
|
for (const type of types) {
|
|
const fields = {}
|
|
const attaches = {
|
|
[type + 'file']: buildAbsoluteFixturePath('avatar-big.png')
|
|
}
|
|
await makeUploadRequest({ url: server.url, path: `${path}/${type}/pick`, token: server.accessToken, fields, attaches })
|
|
}
|
|
})
|
|
|
|
it('Should fail with an unauthenticated user', async function () {
|
|
for (const type of types) {
|
|
const fields = {}
|
|
const attaches = {
|
|
[type + 'file']: buildAbsoluteFixturePath('avatar.png')
|
|
}
|
|
await makeUploadRequest({
|
|
url: server.url,
|
|
path: `${path}/${type}/pick`,
|
|
fields,
|
|
attaches,
|
|
expectedStatus: HttpStatusCode.UNAUTHORIZED_401
|
|
})
|
|
}
|
|
})
|
|
|
|
it('Should succeed with the correct params', async function () {
|
|
for (const type of types) {
|
|
const fields = {}
|
|
const attaches = {
|
|
[type + 'file']: buildAbsoluteFixturePath('avatar.png')
|
|
}
|
|
await makeUploadRequest({
|
|
url: server.url,
|
|
path: `${path}/${type}/pick`,
|
|
token: server.accessToken,
|
|
fields,
|
|
attaches,
|
|
expectedStatus: HttpStatusCode.OK_200
|
|
})
|
|
}
|
|
})
|
|
})
|
|
|
|
describe('When getting a video channel', function () {
|
|
it('Should return the list of the video channels with nothing', async function () {
|
|
const res = await makeGetRequest({
|
|
url: server.url,
|
|
path: videoChannelPath,
|
|
expectedStatus: HttpStatusCode.OK_200
|
|
})
|
|
|
|
expect(res.body.data).to.be.an('array')
|
|
})
|
|
|
|
it('Should return 404 with an incorrect video channel', async function () {
|
|
await makeGetRequest({
|
|
url: server.url,
|
|
path: videoChannelPath + '/super_channel2',
|
|
expectedStatus: HttpStatusCode.NOT_FOUND_404
|
|
})
|
|
})
|
|
|
|
it('Should succeed with the correct parameters', async function () {
|
|
await makeGetRequest({
|
|
url: server.url,
|
|
path: videoChannelPath + '/super_channel',
|
|
expectedStatus: HttpStatusCode.OK_200
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('When getting channel followers', function () {
|
|
const path = '/api/v1/video-channels/super_channel/followers'
|
|
|
|
it('Should fail with a bad start pagination', async function () {
|
|
await checkBadStartPagination(server.url, path, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with a bad count pagination', async function () {
|
|
await checkBadCountPagination(server.url, path, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with an incorrect sort', async function () {
|
|
await checkBadSortPagination(server.url, path, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with a unauthenticated user', async function () {
|
|
await makeGetRequest({ url: server.url, path, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
|
|
})
|
|
|
|
it('Should fail with a another user', async function () {
|
|
await makeGetRequest({ url: server.url, path, token: userInfo.accessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
|
|
})
|
|
|
|
it('Should succeed with the correct params', async function () {
|
|
await makeGetRequest({ url: server.url, path, token: server.accessToken, expectedStatus: HttpStatusCode.OK_200 })
|
|
})
|
|
})
|
|
|
|
describe('When triggering full synchronization', function () {
|
|
|
|
it('Should fail when HTTP upload is disabled', async function () {
|
|
await server.config.disableImports()
|
|
|
|
await command.importVideos({
|
|
channelName: 'super_channel',
|
|
externalChannelUrl: FIXTURE_URLS.youtubeChannel,
|
|
token: server.accessToken,
|
|
expectedStatus: HttpStatusCode.FORBIDDEN_403
|
|
})
|
|
|
|
await server.config.enableImports()
|
|
})
|
|
|
|
it('Should fail when externalChannelUrl is not provided', async function () {
|
|
await command.importVideos({
|
|
channelName: 'super_channel',
|
|
externalChannelUrl: null,
|
|
token: server.accessToken,
|
|
expectedStatus: HttpStatusCode.BAD_REQUEST_400
|
|
})
|
|
})
|
|
|
|
it('Should fail when externalChannelUrl is malformed', async function () {
|
|
await command.importVideos({
|
|
channelName: 'super_channel',
|
|
externalChannelUrl: 'not-a-url',
|
|
token: server.accessToken,
|
|
expectedStatus: HttpStatusCode.BAD_REQUEST_400
|
|
})
|
|
})
|
|
|
|
it('Should fail with no authentication', async function () {
|
|
await command.importVideos({
|
|
channelName: 'super_channel',
|
|
externalChannelUrl: FIXTURE_URLS.youtubeChannel,
|
|
token: null,
|
|
expectedStatus: HttpStatusCode.UNAUTHORIZED_401
|
|
})
|
|
})
|
|
|
|
it('Should fail when sync is not owned by the user', async function () {
|
|
await command.importVideos({
|
|
channelName: 'super_channel',
|
|
externalChannelUrl: FIXTURE_URLS.youtubeChannel,
|
|
token: userInfo.accessToken,
|
|
expectedStatus: HttpStatusCode.FORBIDDEN_403
|
|
})
|
|
})
|
|
|
|
it('Should fail when the user has no quota', async function () {
|
|
await server.users.update({
|
|
userId: userInfo.id,
|
|
videoQuota: 0
|
|
})
|
|
|
|
await command.importVideos({
|
|
channelName: 'fake_channel',
|
|
externalChannelUrl: FIXTURE_URLS.youtubeChannel,
|
|
token: userInfo.accessToken,
|
|
expectedStatus: HttpStatusCode.PAYLOAD_TOO_LARGE_413
|
|
})
|
|
|
|
await server.users.update({
|
|
userId: userInfo.id,
|
|
videoQuota: userInfo.videoQuota
|
|
})
|
|
})
|
|
|
|
it('Should fail when the user has no daily quota', async function () {
|
|
await server.users.update({
|
|
userId: userInfo.id,
|
|
videoQuotaDaily: 0
|
|
})
|
|
|
|
await command.importVideos({
|
|
channelName: 'fake_channel',
|
|
externalChannelUrl: FIXTURE_URLS.youtubeChannel,
|
|
token: userInfo.accessToken,
|
|
expectedStatus: HttpStatusCode.PAYLOAD_TOO_LARGE_413
|
|
})
|
|
|
|
await server.users.update({
|
|
userId: userInfo.id,
|
|
videoQuotaDaily: userInfo.videoQuotaDaily
|
|
})
|
|
})
|
|
|
|
it('Should succeed when sync is run by its owner', async function () {
|
|
if (!areHttpImportTestsDisabled()) return
|
|
|
|
await command.importVideos({
|
|
channelName: 'fake_channel',
|
|
externalChannelUrl: FIXTURE_URLS.youtubeChannel,
|
|
token: userInfo.accessToken
|
|
})
|
|
})
|
|
|
|
it('Should succeed when sync is run with root and for another user\'s channel', async function () {
|
|
if (!areHttpImportTestsDisabled()) return
|
|
|
|
await command.importVideos({
|
|
channelName: 'fake_channel',
|
|
externalChannelUrl: FIXTURE_URLS.youtubeChannel
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('When deleting a video channel', function () {
|
|
it('Should fail with a non authenticated user', async function () {
|
|
await command.delete({ token: 'coucou', channelName: 'super_channel', expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
|
|
})
|
|
|
|
it('Should fail with another authenticated user', async function () {
|
|
await command.delete({ token: userInfo.accessToken, channelName: 'super_channel', expectedStatus: HttpStatusCode.FORBIDDEN_403 })
|
|
})
|
|
|
|
it('Should fail with an unknown video channel id', async function () {
|
|
await command.delete({ channelName: 'super_channel2', expectedStatus: HttpStatusCode.NOT_FOUND_404 })
|
|
})
|
|
|
|
it('Should succeed with the correct parameters', async function () {
|
|
await command.delete({ channelName: 'super_channel' })
|
|
})
|
|
|
|
it('Should fail to delete the last user video channel', async function () {
|
|
await command.delete({ channelName: 'root_channel', expectedStatus: HttpStatusCode.CONFLICT_409 })
|
|
})
|
|
})
|
|
|
|
after(async function () {
|
|
await cleanupTests([ server ])
|
|
})
|
|
})
|