borekon/PeerTube_original
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix mention notification with deleted comment

Browse Source
This commit is contained in:
Chocobozzz 2021-03-22 09:49:23 +01:00
parent 42ec411bf8
commit 61fd98341f
No known key found for this signature in database
GPG Key ID: 583A612D890159BE
2 changed files with 21 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
client/src/app/shared/shared-main/users/user-notifications.component.html
View File

@ -90,9 +90,7 @@
</ng-container> </ng-container>
<ng-container *ngSwitchCase="UserNotificationType.NEW_COMMENT_ON_MY_VIDEO"> <ng-container *ngSwitchCase="UserNotificationType.NEW_COMMENT_ON_MY_VIDEO">
<ng-container *ngIf="notification.comment; then hasComment; else noComment"></ng-container> <ng-container *ngIf="notification.comment">
<ng-template #hasComment>
<a (click)="markAsRead(notification)" [routerLink]="notification.accountUrl"> <a (click)="markAsRead(notification)" [routerLink]="notification.accountUrl">
<img alt="" aria-labelledby="avatar" class="avatar" [src]="notification.comment.account.avatarUrl" /> <img alt="" aria-labelledby="avatar" class="avatar" [src]="notification.comment.account.avatarUrl" />
</a> </a>
@ -100,15 +98,15 @@
<div class="message" i18n> <div class="message" i18n>
<a (click)="markAsRead(notification)" [routerLink]="notification.accountUrl">{{ notification.comment.account.displayName }}</a> commented your video <a (click)="markAsRead(notification)" [routerLink]="notification.commentUrl">{{ notification.comment.video.name }}</a> <a (click)="markAsRead(notification)" [routerLink]="notification.accountUrl">{{ notification.comment.account.displayName }}</a> commented your video <a (click)="markAsRead(notification)" [routerLink]="notification.commentUrl">{{ notification.comment.video.name }}</a>
</div> </div>
</ng-template> </ng-container>
<ng-template #noComment> <ng-container *ngIf="!notification.comment">
<my-global-icon iconName="alert" aria-hidden="true"></my-global-icon> <my-global-icon iconName="alert" aria-hidden="true"></my-global-icon>
<div class="message" i18n> <div class="message" i18n>
The notification concerns a comment now unavailable The notification concerns a comment now unavailable
</div> </div>
</ng-template> </ng-container>
</ng-container> </ng-container>
<ng-container *ngSwitchCase="UserNotificationType.MY_VIDEO_PUBLISHED"> <ng-container *ngSwitchCase="UserNotificationType.MY_VIDEO_PUBLISHED">
@ -157,6 +155,7 @@
</ng-container> </ng-container>
<ng-container *ngSwitchCase="UserNotificationType.COMMENT_MENTION"> <ng-container *ngSwitchCase="UserNotificationType.COMMENT_MENTION">
<ng-container *ngIf="notification.comment">
<a (click)="markAsRead(notification)" [routerLink]="notification.accountUrl"> <a (click)="markAsRead(notification)" [routerLink]="notification.accountUrl">
<img alt="" aria-labelledby="avatar" class="avatar" [src]="notification.comment.account.avatarUrl" /> <img alt="" aria-labelledby="avatar" class="avatar" [src]="notification.comment.account.avatarUrl" />
</a> </a>
@ -166,6 +165,15 @@
</div> </div>
</ng-container> </ng-container>
<ng-container *ngIf="!notification.comment">
<my-global-icon iconName="alert" aria-hidden="true"></my-global-icon>
<div class="message" i18n>
The notification concerns a comment now unavailable
</div>
</ng-container>
</ng-container>
<ng-container *ngSwitchCase="UserNotificationType.NEW_INSTANCE_FOLLOWER"> <ng-container *ngSwitchCase="UserNotificationType.NEW_INSTANCE_FOLLOWER">
<my-global-icon iconName="users" aria-hidden="true"></my-global-icon> <my-global-icon iconName="users" aria-hidden="true"></my-global-icon>

2
server/tests/api/moderation/blocklist.ts
View File

@ -107,7 +107,7 @@ describe('Test blocklist', function () {
let userToken2: string let userToken2: string
before(async function () { before(async function () {
this.timeout(60000) this.timeout(120000)
servers = await flushAndRunMultipleServers(3) servers = await flushAndRunMultipleServers(3)
await setAccessTokensToServers(servers) await setAccessTokensToServers(servers)